Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add code to extract level set paths and lengths #70

Merged
merged 6 commits into from
Dec 16, 2024
Merged

add code to extract level set paths and lengths #70

merged 6 commits into from
Dec 16, 2024

Conversation

m-reuter
Copy link
Member

Here we add code to:

  1. compute the accumulated length of a level set, by finding intersecting points at edges in each triangle. This works for arbitrary level sets and can also loop over multiple level values.
  2. extract a level set path for a single curve with start and end point and compute its length. This function also uses a helper function (wrapper around shortest_path) to sort undirected edges into a single path quickly.

The idea is to add this to the next minor release.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 7.75862% with 107 lines in your changes missing coverage. Please review.

Project coverage is 33.62%. Comparing base (2cbcee0) to head (5bb781d).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
lapy/tria_mesh.py 7.07% 105 Missing ⚠️
lapy/diffgeo.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
- Coverage   34.89%   33.62%   -1.27%     
==========================================
  Files          14       14              
  Lines        2370     2483     +113     
  Branches      286      301      +15     
==========================================
+ Hits          827      835       +8     
- Misses       1458     1563     +105     
  Partials       85       85              
Flag Coverage Δ
unittests 33.62% <7.75%> (-1.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m-reuter m-reuter merged commit 416fd9a into main Dec 16, 2024
26 of 28 checks passed
@m-reuter m-reuter deleted the levelset branch December 16, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant